From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: set SB_I_NOEXEC on the pseudo filesystem Date: Mon, 25 May 2026 21:11:47 +1000 Message-ID: In-Reply-To: <20260520214350.168689-1-jhubbard@nvidia.com> References: <20260520214350.168689-1-jhubbard@nvidia.com> <20260520214350.168689-1-jhubbard@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The one-line change is placed at the right location = =E2=80=94 inside `dma_buf_fs_init_context()`, after `init_pseudo()` succeed= s and before returning. The field `fc->s_iflags` is defined in `struct fs_c= ontext` (at `include/linux/fs_context.h:106`) and is documented as being OR= 'd into `sb->s_iflags` during superblock creation, so this will propagate c= orrectly. ```c ctx->dops =3D &dma_buf_dentry_ops; + fc->s_iflags |=3D SB_I_NOEXEC; return 0; ``` This exactly mirrors the pattern in `anon_inodefs_init_fs_context()` at `fs= /anon_inodes.c:89`: ```c fc->s_iflags |=3D SB_I_NOEXEC; ``` **Commit message: Good.** The commit message clearly explains: - What the bug is (missing `SB_I_NOEXEC` on dmabuf superblock) - What triggers it (the new `path_noexec()` assertion from 6.17) - The exact warning stack trace - A concrete reproducer using the dma_heap selftest - Why the fix is correct (dma-bufs have no business being executable) **Fixes tag: Correct.** Points to `1e7ab6f67824` which introduced the asser= tion that now fires. This is the right commit to cite since dma-buf was wor= king before that assertion was added. **Minor nit (non-blocking):** The placement of `fc->s_iflags |=3D SB_I_NOEX= EC` after `ctx->dops =3D &dma_buf_dentry_ops` works but conventionally othe= r filesystems tend to set the iflags before other context setup (as in `ano= n_inodes.c`). This is purely cosmetic and doesn't affect correctness at all. **Verdict: Looks good.** Clean, minimal, correct fix. Ready to merge. --- Generated by Claude Code Patch Reviewer