Claude review: drm/amdgpu: Unify vm_fault_interrupt_state logic for gmc v10 and v12_0

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Correctness: Good.** The extracted function is a faithful copy of the code removed from both files. The `.set` callback pointer swap is correct.

**Issue 1 — Co-developed-by / Signed-off-by ordering (must fix)**

The current tag ordering is:
```
Signed-off-by: Ryan Oliveira <ryan.oliveiraf@usp.br>
Co-developed-by: Kaiky Cintra <kaikycintra@usp.br>
Signed-off-by: Kaiky Cintra <kaikycintra@usp.br>
```

Per `Documentation/process/submitting-patches.rst`, the submitter's (From: author's) `Signed-off-by` must be last, and each `Co-developed-by` must be immediately followed by the corresponding `Signed-off-by`. The correct ordering is:

```
Co-developed-by: Kaiky Cintra <kaikycintra@usp.br>
Signed-off-by: Kaiky Cintra <kaikycintra@usp.br>
Signed-off-by: Ryan Oliveira <ryan.oliveiraf@usp.br>
```

**Issue 2 — Extra blank line (nit)**

There's a double blank line between the new function and `amdgpu_gmc_ras_sw_init`:

```c
	return 0;
}


int amdgpu_gmc_ras_sw_init(struct amdgpu_device *adev)
```

Kernel style uses a single blank line between functions.

**Issue 3 — gmc_v11_0 has a near-identical copy that could also be consolidated (suggestion)**

`gmc_v11_0.c` has an almost identical implementation, differing only in the `DISABLE` case where it adds an extra condition:

```c
// gmc_v11_0 DISABLE case:
if (!adev->in_s0ix && (adev->in_runpm || adev->in_suspend ||
                       amdgpu_in_reset(adev)))
    amdgpu_gmc_set_vm_fault_masks(adev, AMDGPU_GFXHUB(0), false);

// gmc_v10_0 / gmc_v12_0 (and the new shared helper) DISABLE case:
if (!adev->in_s0ix)
    amdgpu_gmc_set_vm_fault_masks(adev, AMDGPU_GFXHUB(0), false);
```

The ENABLE paths are identical across all three. This isn't a blocker for this patch, but the commit message could briefly note why gmc_v11_0 was intentionally excluded (different DISABLE logic) so future readers don't wonder. It's also worth considering whether gmc_v11_0 could be consolidated with a flag or callback parameter, but that's a separate patch.

Note: `gmc_v12_1`, `gmc_v9_0`, and the older versions (v6/v7/v8) all have structurally different implementations (register-level iteration, different hub handling), so they are correctly left untouched.

**Summary:** Correct and useful deduplication. Fix the SoB ordering and the extra blank line, and optionally note why gmc_v11_0 was left out.

---
Generated by Claude Code Patch Reviewer