From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: mfd: tps6586x: fix OF node refcount Date: Mon, 25 May 2026 20:33:06 +1000 Message-ID: In-Reply-To: <20260521-pdev-fwnode-ref-v1-1-88c324a1b8d2@oss.qualcomm.com> References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> <20260521-pdev-fwnode-ref-v1-1-88c324a1b8d2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Correct fix. The device is created via `platform_device_alloc()`, and `platform_device_release()` unconditionally calls `of_node_put()`. Without the matching `of_node_get()`, this is an unbalanced put. ```c - pdev->dev.of_node = subdev->of_node; + pdev->dev.of_node = of_node_get(subdev->of_node); ``` Appropriate Fixes/Cc-stable tags present. No issues. --- Generated by Claude Code Patch Reviewer