From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panthor: Expose GPU page sizes to UM Date: Mon, 25 May 2026 21:08:32 +1000 Message-ID: In-Reply-To: <20260521014359.2011484-2-adrian.larumbe@collabora.com> References: <20260521014359.2011484-1-adrian.larumbe@collabora.com> <20260521014359.2011484-2-adrian.larumbe@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean and straightforward. Adds `drm_panthor_mmu_info` with a `page_size_bitmap` field and wires it through the device query path. No issues. The bitmap is currently hardcoded to `SZ_4K | SZ_2M` in `panthor_mmu_info_init()`, which correctly matches the prior hardcoded value in `pgtbl_cfg`. The uAPI struct uses `__u64` which is appropriate for a bitmap that may grow. One minor observation: `panthor_mmu_info_init()` is called early in `panthor_mmu_init()` before any allocation, which is fine since it's just setting a constant. --- Generated by Claude Code Patch Reviewer