From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Move fdlist to invoke context structure Date: Mon, 25 May 2026 20:54:21 +1000 Message-ID: In-Reply-To: <20260521054539.128651-2-ekansh.gupta@oss.qualcomm.com> References: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> <20260521054539.128651-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good.** This moves the `fdlist` pointer from being locally computed in both `fastrpc_get_args()` and `fastrpc_put_args()` into the `struct fastrpc_invoke_ctx`. This eliminates redundant computation and is also necessary for patch 4 to calculate `poll_addr` relative to the end of the metadata buffer. One subtle correctness point: the old code in `fastrpc_put_args()` computed `fdlist` as: ```c fdlist = (uint64_t *)(pages + inbufs + outbufs + handles); ``` while the new code in `fastrpc_get_args()` computes it as: ```c ctx->fdlist = (u64 *)(pages + ctx->nscalars); ``` These are equivalent because `nscalars = inbufs + outbufs + handles` (see `REMOTE_SCALARS_LENGTH`), so this is correct and also simpler. Has R-b from Dmitry Baryshkov. No issues. --- Generated by Claude Code Patch Reviewer