From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: analogix_dp: Convert status check functions to bool Date: Mon, 25 May 2026 20:22:40 +1000 Message-ID: In-Reply-To: <20260521102716.1373519-1-damon.ding@rock-chips.com> References: <20260521102716.1373519-1-damon.ding@rock-chips.com> <20260521102716.1373519-1-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness =E2=80=94 OK.** The key semantic question is whether the inve= rsion is handled correctly: - **Original:** `return 0` means "clock/stream IS on", callers test `if (fu= nc() =3D=3D 0)` to enter the success path. - **New:** `return true` means "clock/stream IS on", callers test `if (func= ())` to enter the success path. Both call sites are correct after the change: ```c // analogix_dp_core.c, first loop (slave video stream clock): - if (analogix_dp_is_slave_video_stream_clock_on(dp) =3D=3D 0) + if (analogix_dp_is_slave_video_stream_clock_on(dp)) break; ``` ```c // analogix_dp_core.c, second loop (video stream on): - if (analogix_dp_is_video_stream_on(dp) =3D=3D 0) { + if (analogix_dp_is_video_stream_on(dp)) { done_count++; ``` Both loops preserve identical behavior =E2=80=94 the `else if (done_count)`= branch in the second loop is also unaffected since the boolean false case = maps exactly to the old non-zero case. **Scope =E2=80=94 OK.** Both functions are static-linkage internal to the a= nalogix_dp driver. There are no other callers anywhere in the tree. The hea= der, implementation, and call sites are all updated consistently. **No issues found.** This is a clean, correct cleanup patch. --- Generated by Claude Code Patch Reviewer