From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: panel: Move Logic Technologies LT170410-2WHC to LVDS Date: Mon, 25 May 2026 19:56:37 +1000 Message-ID: In-Reply-To: <20260521150038.103538-18-ivitro@gmail.com> References: <20260521150038.103538-17-ivitro@gmail.com> <20260521150038.103538-18-ivitro@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This moves the `logictechno,lt170410-2whc` compatible from `panel-simple.yaml` to `panel-lvds.yaml`. **Potential regression concern**: If any existing DTS in-tree uses `logictechno,lt170410-2whc` as a simple panel (without `panel-lvds` as a fallback compatible), removing it from `panel-simple.yaml` could break existing board support. The patch author does use dual compatibles in the DTS patches (e.g., `"logictechno,lt170410-2whc", "panel-lvds"`), but existing upstream users may not. **Indentation issue in panel-simple.yaml**: The removal leaves the comment for the next entry misaligned. In the original file: ``` - logictechno,lt161010-2nhr - # Logic Technologies LT170410-2WHC 10.1" 1280x800 IPS TFT Cap Touch Mod. - - logictechno,lt170410-2whc # Logic Technologies LTTD800480070-L2RT 7" 800x480 TFT Resistive Touch Module ``` The comment `# Logic Technologies LTTD800480070-L2RT...` keeps its extra indentation (8 spaces vs the 6 spaces for the entry below it), but this was already the existing style in panel-simple.yaml, so it's fine. The panel-lvds.yaml addition looks correctly alphabetically ordered. --- Generated by Claude Code Patch Reviewer