From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: chipone-icn6211: use devm_mipi_dsi_attach
Date: Mon, 25 May 2026 19:34:35 +1000
Message-ID: <review-patch1-20260521212529.151493-1-osama.abdelkader@gmail.com>
In-Reply-To: <20260521212529.151493-1-osama.abdelkader@gmail.com>
References: <20260521212529.151493-1-osama.abdelkader@gmail.com> <20260521212529.151493-1-osama.abdelkader@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Change summary:** Converts `mipi_dsi_attach(dsi)` to `devm_mipi_dsi_attac=
h(dev, dsi)` in `chipone_dsi_attach()`, then removes the now-empty `chipone=
_dsi_remove()` callback and its registration in the driver struct.

**Correctness:**

The `dev` parameter passed to `devm_mipi_dsi_attach`:

```c
static int chipone_dsi_attach(struct chipone *icn)
{
	struct mipi_dsi_device *dsi =3D icn->dsi;
	struct device *dev =3D icn->dev;
	...
	ret =3D devm_mipi_dsi_attach(dev, dsi);
```

This function is called from two probe paths:

1. **DSI probe** (`chipone_dsi_probe`): `icn->dev` =3D `&dsi->dev`, so the =
detach action is tied to the DSI device. Correct =E2=80=94 matches the old =
`chipone_dsi_remove` behavior.

2. **I2C probe** (`chipone_i2c_probe` =E2=86=92 `chipone_dsi_host_attach` =
=E2=86=92 `chipone_dsi_attach`): `icn->dev` =3D `&client->dev` (the I2C dev=
ice). The detach action is tied to the I2C device lifecycle. This is actual=
ly an **improvement** over the current tree =E2=80=94 the I2C driver has no=
 `.remove` callback, so `mipi_dsi_detach` was never called on I2C device re=
moval. With this patch, managed cleanup handles it correctly.

**Removal of `chipone_dsi_remove`:** The patch is based on a tree where the=
 prior `devm_drm_bridge_add()` conversion already removed `drm_bridge_remov=
e()` from this callback, leaving only `mipi_dsi_detach(dsi)`. Since that's =
now handled by `devm_mipi_dsi_attach`, the entire callback becomes empty an=
d can be safely removed. The current drm-next tree still has `drm_bridge_re=
move()` in `chipone_dsi_remove()` at line 771, which is why the patch doesn=
't apply cleanly =E2=80=94 it depends on the prior conversion landing first.

**No issues found.** The patch is straightforward and correct.

Reviewed-by: Dave Airlie <airlied@gmail.com>

---
Generated by Claude Code Patch Reviewer