From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Replace controller runtime_get/put callbacks with direct PM runtime APIs Date: Mon, 25 May 2026 19:03:03 +1000 Message-ID: In-Reply-To: <20260522-mhi_runtimepm-v2-1-fbebf41a82bb@oss.qualcomm.com> References: <20260522-mhi_runtimepm-v2-0-fbebf41a82bb@oss.qualcomm.com> <20260522-mhi_runtimepm-v2-1-fbebf41a82bb@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean mechanical replacement. The change from `mhi_cntrl->runtime_get(mhi_cntrl)` / `mhi_cntrl->runtime_put(mhi_cntrl)` to `pm_runtime_get(mhi_cntrl->cntrl_dev)` / `pm_runtime_put(mhi_cntrl->cntrl_dev)` with `pm_runtime_mark_last_busy()` before each put is correct. One minor concern: in `mhi_queue()`, the `pm_runtime_get()` (async variant) is used: ```c - mhi_cntrl->runtime_get(mhi_cntrl); + pm_runtime_get(mhi_cntrl->cntrl_dev); ``` The original `mhi_pci_runtime_get` (removed in patch 2) also called `pm_runtime_get()`, so this is a faithful conversion. The comment above this call site documents the get/put balancing scheme for TX vs RX paths, which remains intact. No issues found. --- Generated by Claude Code Patch Reviewer