From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/print: describe 6th & 9th bit of drm.debug Date: Mon, 25 May 2026 18:29:27 +1000 Message-ID: In-Reply-To: <20260522135520.1862848-2-michal.grzelak@intel.com> References: <20260522135520.1862848-1-michal.grzelak@intel.com> <20260522135520.1862848-2-michal.grzelak@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch adds the missing `Bit 6 (STATE)` and `Bit 9 (DRMRES)` entries to= the `MODULE_PARM_DESC` string, and fixes the "enable all" comment from `0x= 1ff` to `0x3ff`. **Correctness:** I verified against the enum `drm_debug_category` in `inclu= de/drm/drm_print.h:98-142` and the `DECLARE_DYNDBG_CLASSMAP` in `drivers/gp= u/drm/drm_print.c:60-70`. There are 10 categories (bits 0=E2=80=939): | Bit | Enum | Present in MODULE_PARM_DESC? | |-----|------|-----| | 0=E2=80=935 | CORE through VBL | Yes (already) | | 6 | DRM_UT_STATE | **Missing =E2=86=92 added by patch** | | 7 | DRM_UT_LEASE | Yes (already) | | 8 | DRM_UT_DP | Yes (already) | | 9 | DRM_UT_DRMRES | **Missing =E2=86=92 added by patch** | The descriptions match the enum comments: - `DRM_UT_STATE` =E2=86=92 "Used for verbose atomic state debugging" =E2=86= =92 patch uses "STATE messages (atomic state code)" =E2=80=94 consistent wi= th the existing style. - `DRM_UT_DRMRES` =E2=86=92 "Used in the drm managed resources code" =E2=86= =92 patch uses "DRMRES messages (managed resources code)" =E2=80=94 correct. The bitmask fix from `0x1ff` (bits 0=E2=80=938) to `0x3ff` (bits 0=E2=80=93= 9) is also correct, since 10 categories need 10 bits. **Minor nit (non-blocking):** The subject says "6th & 9th bit" but the code= adds "Bit 6" and "Bit 9" (0-indexed). "6th bit" in natural language would = traditionally be bit 5. Consider "bit 6 & bit 9" in the subject for precisi= on, though this is entirely cosmetic. **Reviewed-by worthy:** Yes. --- Generated by Claude Code Patch Reviewer