From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: novatek-nt36672a: Inline panel init sequences
Date: Mon, 25 May 2026 17:59:28 +1000
Message-ID: <review-patch1-20260523035734.6602-1-chintanlike@gmail.com>
In-Reply-To: <20260523035734.6602-1-chintanlike@gmail.com>
References: <20260523035734.6602-1-chintanlike@gmail.com> <20260523035734.6602-1-chintanlike@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Correctness: Good.** The conversion from table-driven to inline is faithf=
ul. All loop ranges are correct, all values match, and the `0x1` vs `0x01` =
difference in the original `0xFB` register write is a non-issue (identical =
in C).

**Minor nit =E2=80=94 unnecessary NULL checks on function pointers:**

```c
if (pinfo->desc->send_deinit_cmds)
    pinfo->desc->send_deinit_cmds(&dsi_ctx);
```

```c
if (pinfo->desc->send_init_cmds_1)
    pinfo->desc->send_init_cmds_1(&dsi_ctx);
```

```c
if (pinfo->desc->send_init_cmds_2)
    pinfo->desc->send_init_cmds_2(&dsi_ctx);
```

The original code passed `off_cmds` / `on_cmds_1` / `on_cmds_2` uncondition=
ally (a NULL pointer with `num=3D0` would just skip the loop). Since there =
is currently only one panel variant (`tianma_fhd_video_panel_desc`) and it =
sets all three function pointers, these NULL checks are strictly unnecessar=
y today. However, they are **reasonable defensive coding** for when future =
panel variants are added that might not need all three init phases =E2=80=
=94 so this is a fine design choice. No action needed.

**`accum_err` propagation:** The function pointer calls don't check or prop=
agate `dsi_ctx.accum_err` themselves, but they don't need to =E2=80=94 the =
`_multi` helpers internally short-circuit on `accum_err !=3D 0`, and the ca=
llers (`prepare`/`unprepare`) already handle or reset errors at the appropr=
iate points. This matches the existing behavior.

**Style:** Hex values correctly lowercased per v3 changelog. Comments prese=
rved where meaningful (skin enhancement mode, UI/STILL/MOVING mode, dimming=
, resolution).

**No functional change** beyond the refactoring itself =E2=80=94 the same b=
ytes get written to the same registers in the same order.

Reviewed-by worthy as-is.

---
Generated by Claude Code Patch Reviewer