Claude review: drm/gma500: clean up modeset on backlight init failure

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**The fix itself is correct and straightforward.**

At line 407-408 (post-patch):
```c
	if (ret)
		goto out_err;
```

This replaces the previous `return ret`, ensuring that `psb_driver_unload()` at the `out_err:` label (line 413-415) is called, which properly tears down the modeset, IRQs, MMU, etc.

**Minor observation on `ret` value scope:** The variable `ret` is set inside the connector loop only if an LVDS or MIPI connector is found and `gma_backlight_init()` is called. If no such connector exists, `ret` still holds its value from the last assignment before the loop. Looking at the code path, the last assignment to `ret` before the connector loop is at line 367:
```c
	ret = drm_vblank_init(dev, dev_priv->num_pipe);
	if (ret)
		goto out_err;
```

If `drm_vblank_init()` succeeded, `ret == 0`, so the `if (ret)` check at line 407 correctly falls through to the success path. This is fine — no issue here, just confirming the logic holds.

**Pre-existing issue (out of scope for this patch):** At line 348-350, there's another bare `return ret` that also skips `out_err`:
```c
	ret = psb_do_init(dev);
	if (ret)
		return ret;
```

This has the same class of bug — resources initialized before `psb_do_init()` (MMU page directory, scratch page, GTT, GEM) won't be cleaned up. The submitter might consider a follow-up patch for this.

**Tags review:** The Fixes tag references commit `1f90b1773` ("drm/gma500: Refactor backlight support (v2)"), which is the commit that introduced the backlight init in this location. The Cc: stable tag is appropriate since this is a real resource leak fix.

**Recommendation:** Apply as-is. Optionally suggest the author send a follow-up for the `psb_do_init()` bare return at line 349.

---
Generated by Claude Code Patch Reviewer