From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/meson: clean up KMS polling on register failure Date: Mon, 25 May 2026 17:01:27 +1000 Message-ID: In-Reply-To: <20260524160657.17802-1-mhun512@gmail.com> References: <20260524160657.17802-1-mhun512@gmail.com> <20260524160657.17802-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Correct.** The initialization sequence in `meson_drv_bind_master()` is: ```c // line 343: request_irq(priv->vsync_irq, ...) // line 349: drm_kms_helper_poll_init(drm) // line 353: drm_dev_register(drm, 0) ``` The error unwind must be in reverse order: poll_fini =E2=86=92 free_irq. Th= e patch achieves this correctly: ```c uninstall_poll: drm_kms_helper_poll_fini(drm); uninstall_irq: free_irq(priv->vsync_irq, drm); ``` This also matches the normal teardown order in `meson_drv_unbind()` (lines = 406-409), which does `drm_dev_unregister` =E2=86=92 `drm_kms_helper_poll_fi= ni` =E2=86=92 `free_irq`. **Fixes tag:** The `Fixes:` tag references `bbbe775ec5b5 ("drm: Add support= for Amlogic Meson Graphic Controller")`, which is the commit that introduc= ed this function. This is appropriate since the bug has existed since the o= riginal code. **Stable tag:** The `Cc: stable@vger.kernel.org` tag is appropriate for a r= esource-leak/use-after-free fix on an error path. **No issues found.** The patch is minimal, correct, and well-described. The= commit message accurately explains the problem and the fix. --- Generated by Claude Code Patch Reviewer