From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: Document Renesas RZ/G3L LVDS encoder Date: Mon, 25 May 2026 16:56:34 +1000 Message-ID: In-Reply-To: <20260524194457.479681-2-biju.das.jz@bp.renesas.com> References: <20260524194457.479681-1-biju.das.jz@bp.renesas.com> <20260524194457.479681-2-biju.das.jz@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch adds the YAML DT binding for `renesas,r9a08g046-lvds`. It is wel= l-written and already carries an Acked-by. **Minor nits:** 1. **Description typo**: Line 803 says `"This binding describe"` =E2=80=94 = should be `"This binding describes"`. 2. **Reset ordering**: The binding defines resets as `lvdrst, prst, rst, ar= st`, which is fine, but the driver acquires `rst` and `arst` as `_optional_= exclusive` while `prst` and `lvdrst` are `_shared`. It would be helpful to = document in the binding description which resets are shared with the DSI mo= dule, since the cover letter text explains this constraint but the binding = doesn't. 3. **Example node naming**: The example uses `lvds-cmn@108a0000` as the par= ent syscon MFD node and `lvds@10` as the child. This looks correct for a sy= scon child node with relative register offsets. Overall this patch looks good. No blocking issues. --- --- Generated by Claude Code Patch Reviewer