From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint Date: Tue, 26 May 2026 07:20:31 +1000 Message-ID: In-Reply-To: <20260525094731.121380-2-damon.ding@rock-chips.com> References: <20260525094731.121380-1-damon.ding@rock-chips.com> <20260525094731.121380-2-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Looks good overall.** The binding change correctly switches `port@1` from= `$ref: /schemas/graph.yaml#/properties/port` to `$ref: /schemas/graph.yaml= #/$defs/port-base` to allow extending the port definition, and adds the `da= ta-lanes` property with appropriate constraints. Minor observations: 1. **`data-lanes` enum values**: The enum `[ 0, 1, 2, 3 ]` correctly constr= ains individual lane values to valid physical lane indices. The `minItems: = 1` / `maxItems: 4` bounds are correct since the driver code fills in unspec= ified lanes with the remaining unused ones. 2. **Example only shows 2 lanes**: The example in `rockchip,analogix-dp.yam= l` adds `data-lanes =3D <0 1>;` which is fine to demonstrate partial lane s= pecification, though it uses the default identity mapping. A more illustrat= ive example might have shown a swap (e.g., `<1 0>`), but this is not a func= tional issue. 3. **`unevaluatedProperties: false` on both port and endpoint**: Good =E2= =80=94 this was requested in v3 review feedback and correctly prevents unre= cognized properties. No issues requiring changes. --- Generated by Claude Code Patch Reviewer