From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/dp: Add DSC virtual DPCD quirk for Realtek MST branch device Date: Tue, 26 May 2026 07:08:44 +1000 Message-ID: In-Reply-To: <20260525125516.2794636-1-imre.deak@intel.com> References: <20260525125516.2794636-1-imre.deak@intel.com> <20260525125516.2794636-1-imre.deak@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Code change:** ```c /* Realtek DP1.4 MST hubs can support DSC without virtual DPCD */ { OUI(0x00, 0xe0, 0x4c), DEVICE_ID('D', 'p', '1', '.', '4', 0), true, BIT(D= P_DPCD_QUIRK_DSC_WITHOUT_VIRTUAL_DPCD) }, ``` **Observations:** 1. **Correct placement**: The new entry is inserted directly after the exis= ting Synaptics `DSC_WITHOUT_VIRTUAL_DPCD` entry (line 2548), grouping relat= ed quirks together. Good. 2. **OUI `00:e0:4c`**: This is Realtek's registered IEEE OUI. Correct. 3. **Specific device ID vs. DEVICE_ID_ANY**: Unlike the Synaptics entry whi= ch uses `DEVICE_ID_ANY` (matching all Synaptics branch devices), this patch= specifies a particular device ID string `"Dp1.4\0"`. This is a more conser= vative approach =E2=80=94 it limits the quirk to only the specific Realtek = device that has been tested, rather than all Realtek MST hubs. This is appr= opriate since Realtek may ship other MST devices where this quirk might not= apply. 4. **Null byte in device ID**: The sixth byte is `0` (null), not a printabl= e character. Looking at the quirk matching logic in `drm_dp_get_quirks()` (= line 2590-2591), the device_id comparison uses `memcmp` over the full 6-byt= e array, so a null byte is compared correctly =E2=80=94 it's treated as dat= a, not a string terminator. No issue here. 5. **`is_branch =3D true`**: Correct =E2=80=94 this is an MST branch device= (hub), not a sink. 6. **Commit message quality**: The commit message properly explains the pro= blem (no discoverable peer-to-peer virtual device), the hardware context (A= SUS DC301 dock with Realtek MST), and the solution (reuse the existing quir= k). It includes `Reported-and-tested-by` and `Cc` tags appropriately. **No issues found.** This is a clean, minimal, well-tested quirk addition f= ollowing established patterns. Reviewed-by criteria: **Acceptable as-is.** --- Generated by Claude Code Patch Reviewer