From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: verisilicon: fix build failure of cursor plane code Date: Tue, 26 May 2026 06:48:27 +1000 Message-ID: In-Reply-To: <20260525153618.1336239-1-zhengxingda@iscas.ac.cn> References: <20260525153618.1336239-1-zhengxingda@iscas.ac.cn> <20260525153618.1336239-1-zhengxingda@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good** The patch changes the second parameter of four plane atomic hooks from `str= uct drm_atomic_state *` to `struct drm_atomic_commit *`: 1. `vs_cursor_plane_atomic_check` =E2=80=94 confirmed matches vtable signat= ure at `drm_modeset_helper_vtables.h:1311` 2. `vs_cursor_plane_atomic_enable` =E2=80=94 confirmed matches vtable signa= ture at `drm_modeset_helper_vtables.h:1353` 3. `vs_cursor_plane_atomic_disable` =E2=80=94 confirmed matches vtable sign= ature at `drm_modeset_helper_vtables.h:1378` 4. `vs_cursor_plane_atomic_update` =E2=80=94 confirmed matches vtable signa= ture at `drm_modeset_helper_vtables.h:1328` All four functions pass `state`/`atomic_state` directly to `drm_atomic_get_= new_plane_state()` or `drm_atomic_get_old_plane_state()`, both of which alr= eady take `const struct drm_atomic_commit *` (confirmed at `drm_atomic.h:82= 4` and `drm_atomic.h:809`). So the type change is sufficient and no other c= ode in the function bodies needs updating. The commit message clearly explains the situation =E2=80=94 the cursor plan= e patch was stalled long enough that the rename happened underneath it. The `Fixes:` tag correctly references the commit that introduced the stale = type. No concerns with this patch. --- Generated by Claude Code Patch Reviewer