From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: drm: tyr: separate driver type from driver data
Date: Wed, 27 May 2026 15:26:02 +1000
Message-ID: <review-patch1-20260525230152.277820-2-dakr@kernel.org>
In-Reply-To: <20260525230152.277820-2-dakr@kernel.org>
References: <20260525230152.277820-1-dakr@kernel.org> <20260525230152.277820-2-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

This patch introduces `TyrPlatformDriver` as a unit struct and moves the `platform::Driver` trait impl onto it, with `TyrPlatformDriverData` becoming the `type Data<'bound>` associated type.

The changes are straightforward and correct:

- **driver.rs**: New `pub(crate) struct TyrPlatformDriver;`, trait impl moved from `TyrPlatformDriverData` to `TyrPlatformDriver`, probe signature gains explicit `'bound` lifetime, return type changes from `impl PinInit<Self, Error>` to `impl PinInit<Self::Data<'bound>, Error>`.
- **tyr.rs**: `module_platform_driver!` updated to reference `TyrPlatformDriver`.
- **OF_TABLE**: Reference updated from `<TyrPlatformDriverData as platform::Driver>::IdInfo` to `<TyrPlatformDriver as platform::Driver>::IdInfo`.

No issues. This is a mechanical separation that follows the pattern required by the new framework.

---
Generated by Claude Code Patch Reviewer