From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/scdc-helper: Don't use ssize_t return type for scdc_read/write Date: Wed, 27 May 2026 15:01:44 +1000 Message-ID: In-Reply-To: <20260526-scdc-link-health-v3-1-59e4a4aaead1@collabora.com> References: <20260526-scdc-link-health-v3-0-59e4a4aaead1@collabora.com> <20260526-scdc-link-health-v3-1-59e4a4aaead1@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean, straightforward cleanup. Both functions return 0 on success and negative errno on failure, so `ssize_t` is semantically wrong and `int` is correct. No issues found. The change is consistent between the `.c` and `.h` files, and the inline wrappers `drm_scdc_readb`/`drm_scdc_writeb` already return `int` so the implicit conversion that was happening before is now eliminated. --- Generated by Claude Code Patch Reviewer