Claude review: nouveau/gsp: fix NULL pointer dereference in r535 nvenc/ofs alloc

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Correctness: The fix itself is correct.**

The change from:
```c
if (WARN_ON(IS_ERR(args)))
    return PTR_ERR(args);
```
to:
```c
if (WARN_ON(IS_ERR_OR_NULL(args)))
    return args ? PTR_ERR(args) : -EIO;
```

correctly mirrors the pattern established by `nvkm_gsp_rm_alloc()` in `gsp.h:418-419`:
```c
if (IS_ERR_OR_NULL(argv))
    return argv ? PTR_ERR(argv) : -EIO;
```

**Issue 1 (Medium): Incomplete fix — same bug in ce.c, nvdec.c, nvjpg.c, and r570/ofa.c**

The patch only fixes `r535/nvenc.c` and `r535/ofa.c`, but the exact same `IS_ERR()`-only pattern exists in:
- `r535/ce.c:34` — `if (WARN_ON(IS_ERR(args)))` / `return PTR_ERR(args);`
- `r535/nvdec.c:33` — identical pattern
- `r535/nvjpg.c:33` — identical pattern
- `r570/ofa.c:16` — identical pattern

Additionally, `r535/fifo.c:88` and `r535/device.c:70,124` have the same pattern with `nvkm_gsp_rm_alloc_get()` calls guarded only by `IS_ERR()`. If the fix is warranted for nvenc/ofa, it should be applied to all callers for consistency and to avoid the same class of bug.

**Issue 2 (Nit): Subject line says "ofs" — should be "ofa"**

The subject line reads `fix NULL pointer dereference in r535 nvenc/ofs alloc` but the file being fixed is `ofa.c` (Optical Flow Accelerator). This appears to be a typo: "ofs" should be "ofa".

**Issue 3 (Minor): Choice of `-EIO` for the NULL case**

Using `-EIO` for the NULL return matches the existing `nvkm_gsp_rm_alloc()` convention, so this is consistent. However, `-ENOMEM` might be more semantically appropriate since a NULL return from the underlying RPC get function likely means memory allocation failed. That said, since the existing convention uses `-EIO`, keeping it consistent is fine.

**Summary:** The fix is correct in what it does, but should be expanded to cover all callers of `nvkm_gsp_rm_alloc_get()` that have the same `IS_ERR()`-only check. The subject line typo ("ofs" → "ofa") should also be corrected.

---
Generated by Claude Code Patch Reviewer