From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/edid: extract base section header processing into helper Date: Wed, 27 May 2026 15:16:42 +1000 Message-ID: In-Reply-To: <20260526030254.1460480-2-chen-yu.chen@amd.com> References: <20260526030254.1460480-1-chen-yu.chen@amd.com> <20260526030254.1460480-2-chen-yu.chen@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good.** The refactoring is clean. Extracting the version/primary_use logging and non_desktop check into `drm_displayid_process_base_section_header()` and removing the `break` statement is the right preparation for iterating over additional block types in patch 2. The `base_section_header_processed` flag correctly ensures the base section header is only processed once even as the iterator walks through all blocks (including extension sections). The cover letter correctly notes that `displayid_version()` and `displayid_primary_use()` return values from the base section regardless of which extension section the iterator is in, so processing once is sufficient. One minor style observation: the old code had a `struct drm_display_info *info` local variable in `update_displayid_info()` that is now removed since `info` is accessed inside the helper. This is fine since the variable was only used in the removed code. --- Generated by Claude Code Patch Reviewer