From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: PCI/TPH: expose the enabled TPH requester type
Date: Wed, 27 May 2026 14:35:49 +1000
Message-ID: <review-patch1-20260526144401.1485788-2-zhipingz@meta.com>
In-Reply-To: <20260526144401.1485788-2-zhipingz@meta.com>
References: <20260526144401.1485788-1-zhipingz@meta.com> <20260526144401.1485788-2-zhipingz@meta.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

A small, clean accessor to avoid drivers reaching into `pci_dev` internals.

**Observation: EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL**

```c
u8 pcie_tph_enabled_req_type(struct pci_dev *pdev)
{
	return pdev->tph_req_type;
}
EXPORT_SYMBOL(pcie_tph_enabled_req_type);
```

The existing `pcie_tph_get_st_table_loc` also uses plain `EXPORT_SYMBOL`, s=
o this is consistent with the file's convention. However, many newer PCI su=
bsystem exports use `EXPORT_SYMBOL_GPL`. The PCI maintainers may have a pre=
ference here =E2=80=94 worth confirming, but not a blocker since the file i=
s internally consistent.

**Stub return value:** The `!CONFIG_PCIE_TPH` stub returns `0`, which maps =
to `PCI_TPH_REQ_DISABLE`. This is correct =E2=80=94 callers will see TPH as=
 disabled, which is the safe default.

No other issues. Clean patch.

---
Generated by Claude Code Patch Reviewer