From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: faux: Allow retrieving a bound Device
Date: Wed, 27 May 2026 14:05:18 +1000
Message-ID: <review-patch1-20260526212857.1158294-2-lyude@redhat.com>
In-Reply-To: <20260526212857.1158294-2-lyude@redhat.com>
References: <20260526212857.1158294-1-lyude@redhat.com> <20260526212857.1158294-2-lyude@redhat.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Looks good**

Simple and correct. The `Registration` object is proof of binding, so upgra=
ding the `AsRef` impl from `device::Device` to `device::Device<device::Boun=
d>` is the right thing:

```rust
-impl AsRef<device::Device> for Registration {
-    fn as_ref(&self) -> &device::Device {
+impl AsRef<device::Device<device::Bound>> for Registration {
+    fn as_ref(&self) -> &device::Device<device::Bound> {
```

The invariant update is also correct =E2=80=94 documenting that `Registrati=
on` is proof of binding.

One minor note: this changes the API surface for any existing users of `fau=
x::Registration::as_ref()`. Since faux is relatively new and the Bound type=
state is an important safety property, this should be fine, but worth being=
 aware of downstream.

---
Generated by Claude Code Patch Reviewer