From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: PCI/P2PDMA: Add CONFIG_PCI_P2PDMA_CORE Date: Thu, 28 May 2026 12:28:52 +1000 Message-ID: In-Reply-To: <20260527102319.100128-2-mattev@meta.com> References: <20260527102319.100128-1-mattev@meta.com> <20260527102319.100128-2-mattev@meta.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Splits `CONFIG_PCI_P2PDMA` into a core part (provider lookup) and the full feature (requires `ZONE_DEVICE`). This unblocks vfio-pci on 32-bit platforms. **Observation**: The patch removes the `depends on 64BIT` from `PCI_P2PDMA` but the comment it also removes says: ``` - # - # The need for the scatterlist DMA bus address flag means PCI P2PDMA - # requires 64bit - # - depends on 64BIT ``` This comment was explaining why `64BIT` was needed. Since `ZONE_DEVICE` itself already implies `64BIT` on most architectures (via `MEMORY_HOTPLUG`), the removal is likely fine in practice, but it would be worth confirming that `ZONE_DEVICE` is truly never selectable on 32-bit. If it were, the scatterlist DMA bus address flag concern would resurface. **Minor**: `default n` is unnecessary for a bool Kconfig symbol -- `n` is already the default: ``` +config PCI_P2PDMA_CORE + default n + bool ``` The `#ifdef CONFIG_PCI_P2PDMA` guards in `p2pdma.c` look correct -- the file is now compiled under `_CORE`, and the full P2P functionality is conditionally compiled within it. --- Generated by Claude Code Patch Reviewer