From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ttm/pool: Don't leak LRU list on shutdown Date: Thu, 28 May 2026 12:07:00 +1000 Message-ID: In-Reply-To: <20260527202018.1223912-1-ian.forbes@broadcom.com> References: <20260527202018.1223912-1-ian.forbes@broadcom.com> <20260527202018.1223912-1-ian.forbes@broadcom.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The added `list_lru_destroy(&pt->pages)` is placed a= fter the LRU walk and dispose, which is the right ordering =E2=80=94 all en= tries are drained first, then the LRU infrastructure is freed. This mirrors= the standard `list_lru_init` / `list_lru_destroy` lifecycle used throughou= t the kernel. **Placement within `ttm_pool_type_fini`:** ```c list_lru_walk(&pt->pages, pool_move_to_dispose_list, &dispose, LONG_MAX); ttm_pool_dispose_list(pt, &dispose); list_lru_destroy(&pt->pages); ``` The destroy comes after draining, which is correct. Calling `list_lru_destr= oy` on a non-empty LRU would be a bug, but the walk + dispose above guarant= ee it's empty. **Commit message:** Clear and concise. The `Fixes:` tag correctly reference= s the commit that introduced the `list_lru` conversion. The description of = how it was found (kmemleak + igt hotunplug) is helpful for reviewers. **No issues found.** This is a clean, correct one-line fix. Reviewed-by assessment: **Accept.** No changes needed. --- Generated by Claude Code Patch Reviewer