From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exec: drm_exec.h: eliminate kernel-doc warnings Date: Thu, 28 May 2026 12:04:23 +1000 Message-ID: In-Reply-To: <20260527220018.1231829-1-rdunlap@infradead.org> References: <20260527220018.1231829-1-rdunlap@infradead.org> <20260527220018.1231829-1-rdunlap@infradead.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Change 1 =E2=80=94 `Returns` =E2=86=92 `Returns:`** (line 88 of the mbox) ```diff - * Returns true if the drm_exec object has run into some contention while + * Returns: true if the drm_exec object has run into some contention while ``` Correct. The kernel-doc parser requires the `Returns:` keyword (with colon)= to properly recognize and format return value descriptions. Without the co= lon, kernel-doc emits: ``` Warning: include/drm/drm_exec.h:146 No description found for return value o= f 'drm_exec_is_contended' ``` **Change 2 =E2=80=94 `@exec` =E2=86=92 `@_exec`** (line 97 of the mbox) ```diff - * @exec: drm_exec object + * @_exec: drm_exec object ``` Correct. The `drm_exec_retry()` macro uses `_exec` as its parameter name (w= ith leading underscore, a common pattern for macro arguments to avoid shado= wing), but the kernel-doc comment documented it as `@exec`. This mismatch p= roduces two warnings =E2=80=94 the actual parameter `_exec` is undescribed = and `exec` is flagged as excess. The fix aligns the documentation with the = actual parameter name. **No issues found.** Both changes are straightforward kernel-doc documentat= ion fixes with no functional impact. --- Generated by Claude Code Patch Reviewer