From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imx/dcss: add missing kernel-doc parameters for scaler functions
Date: Thu, 04 Jun 2026 15:09:58 +1000
Message-ID: <review-patch1-20260530195925.5477-1-rosenp@gmail.com>
In-Reply-To: <20260530195925.5477-1-rosenp@gmail.com>
References: <20260530195925.5477-1-rosenp@gmail.com> <20260530195925.5477-1-rosenp@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Correctness: Good.** Both additions match the actual function signatures.

For `dcss_scaler_gaussian_filter()` (line 171=E2=80=93173 of `dcss-scaler.c=
`):
```c
static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
					bool phase0_identity,
					int coef[][PSC_NUM_TAPS])
```
The parameter `phase0_identity` was indeed undocumented and sits between `u=
se_5_taps` and `coef`. The patch correctly inserts `@phase0_identity` in th=
e right position:
```
+ * @phase0_identity: use identity filter for phase 0
```

For `dcss_scaler_filter_design()` (lines 267=E2=80=93270):
```c
static void dcss_scaler_filter_design(int src_length, int dst_length,
				      bool use_5_taps, bool phase0_identity,
				      int coef[][PSC_NUM_TAPS],
				      bool nn_interpolation)
```
Both `phase0_identity` and `nn_interpolation` were missing. The patch adds =
them in the correct order matching the function signature:
```
+ * @phase0_identity: use identity filter for phase 0
  * @coef: output coefficients
+ * @nn_interpolation: use nearest neighbor interpolation
```

**Minor nit:** The `Assisted-by:` tag in the commit message (`Assisted-by: =
Opencode:Big-pickle`) is not a standard kernel tag. The kernel community do=
es not have a formally accepted `Assisted-by:` trailer. If this is intended=
 to credit AI assistance, there's currently no agreed-upon convention for t=
his in the kernel. Maintainers may want the author to drop this tag or use =
a different approach per subsystem policy.

**Verdict:** Trivially correct doc fix. No functional code changes. Looks g=
ood to apply, modulo the non-standard tag question.

---
Generated by Claude Code Patch Reviewer