From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dpu: fix parameter name in dpu_core_perf_adjusted_mode_clk kernel-doc Date: Thu, 04 Jun 2026 15:08:55 +1000 Message-ID: In-Reply-To: <20260530201342.10538-1-rosenp@gmail.com> References: <20260530201342.10538-1-rosenp@gmail.com> <20260530201342.10538-1-rosenp@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status**: Correct. The change at `drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:37`: ``` - * @crtc_clk_rate - Unadjusted mode clock rate + * @mode_clk_rate: unadjusted mode clock rate ``` Verified against the function signature at line 40: ```c u64 dpu_core_perf_adjusted_mode_clk(u64 mode_clk_rate, ``` The parameter is indeed `mode_clk_rate`, not `crtc_clk_rate`. The separator fix from `-` to `:` also aligns with kernel-doc format requirements (kernel-doc uses `@param:` not `@param -`). The capitalization change ("Unadjusted" to "unadjusted") is also consistent with the existing `@perf_cfg` description on the next line which uses lowercase. **Minor note**: The `Assisted-by: Opencode:Big-pickle` tag is non-standard. The kernel community typically uses `Co-developed-by:` for human collaborators, or specific AI-assistance tags that have been discussed on LKML. This is cosmetic and up to the maintainer whether to accept or request a change to the tag. No issues with the code change itself. --- Generated by Claude Code Patch Reviewer