From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/fsl-dcu: Open-code drm_simple_encoder_init()
Date: Thu, 04 Jun 2026 15:05:00 +1000
Message-ID: <review-patch1-20260531073532.8609-2-namanarora029@gmail.com>
In-Reply-To: <20260531073532.8609-2-namanarora029@gmail.com>
References: <20260531073532.8609-1-namanarora029@gmail.com> <20260531073532.8609-2-namanarora029@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Correctness: OK**

The transformation is correct. The new struct:
```c
static const struct drm_encoder_funcs fsl_dcu_drm_encoder_funcs = {
	.destroy = drm_encoder_cleanup,
};
```
is placed at file scope before its first use in `fsl_dcu_drm_encoder_create()`, and the call is correctly changed from:
```c
drm_simple_encoder_init(fsl_dev->drm, encoder, DRM_MODE_ENCODER_LVDS);
```
to:
```c
drm_encoder_init(fsl_dev->drm, encoder, &fsl_dcu_drm_encoder_funcs,
                 DRM_MODE_ENCODER_LVDS, NULL);
```

The `NULL` name argument matches what `drm_simple_encoder_init()` passed. The include removal is safe since no other symbols from `drm_simple_kms_helper.h` are used.

Reviewed-by worthy.

---
Generated by Claude Code Patch Reviewer