From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Revert "backlight: Remove notifier" Date: Thu, 04 Jun 2026 14:54:30 +1000 Message-ID: In-Reply-To: <20260531114908.1693426-2-superm1@kernel.org> References: <20260531114908.1693426-1-superm1@kernel.org> <20260531114908.1693426-2-superm1@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks fine** Straightforward revert restoring the blocking notifier infrastructure. Mino= r nit: the docstring for `backlight_unregister_notifier` still says "Regist= er a notifier" (copy-paste from register): ```c +/** + * backlight_unregister_notifier - unregister a backlight notifier + * @nb: notifier block to unregister + * + * Register a notifier to get notified when backlight devices get register= ed + * or unregistered. ``` Should say "Unregister a notifier..." Also, `BLOCKING_INIT_NOTIFIER_HEAD` is called in `backlight_class_init()` b= ut `backlight_notifier` is file-scope static =E2=80=94 it could use a stati= c initializer (`BLOCKING_NOTIFIER_INIT`) instead, avoiding the runtime init. --- Generated by Claude Code Patch Reviewer