From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: leds: Document TI LM3533 LED controller Date: Thu, 04 Jun 2026 13:59:53 +1000 Message-ID: In-Reply-To: <20260601151831.76350-2-clamor95@gmail.com> References: <20260601151831.76350-1-clamor95@gmail.com> <20260601151831.76350-2-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The three binding schemas (ti,lm3533.yaml, ti,lm3533-backlight.yaml, ti,lm3533-leds.yaml) are well-structured. The `oneOf` constraint for ALS requiring either `ti,resistor-ohms` or `ti,pwm-mode` is correct. The example is comprehensive and covers backlight, LEDs, and ALS nodes. Minor nit: The `ti,pwm-config-mask` property is duplicated identically in both the backlight and LED schemas. Consider defining it once in a shared schema fragment, though this is cosmetic. **No blocking issues.** --- Generated by Claude Code Patch Reviewer