From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: remove cached drm_edid from panel Date: Thu, 04 Jun 2026 13:01:22 +1000 Message-ID: In-Reply-To: <20260602-dp_mstclean-v6-1-2c17ff40a9b2@oss.qualcomm.com> References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> <20260602-dp_mstclean-v6-1-2c17ff40a9b2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean removal of cached `drm_edid` from `msm_dp_panel`. The EDID read is moved to `msm_dp_display_process_hpd_high()` and passed through explicitly. The `msm_dp_panel_put()` function is removed since there's nothing left to free. One observation: after `drm_edid_connector_update(connector, drm_edid)` at line ~420, if `drm_edid` is NULL, the code prints an error and potentially returns `-ETIMEDOUT`, but on the non-timeout path it **falls through** to continue processing with a NULL edid. This matches the old behavior but is worth noting -- a NULL edid on a still-connected link will proceed to `msm_dp_panel_handle_sink_request()` with a NULL `drm_edid`, which will pass NULL to `drm_edid_raw()`. That's safe (returns NULL), so the checksum path is skipped. Fine. **No issues.** --- Generated by Claude Code Patch Reviewer