From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: ptr: rename `ProjectIndex::index` to `build_index` Date: Thu, 04 Jun 2026 12:43:26 +1000 Message-ID: In-Reply-To: <20260602-projection-syntax-rework-v2-1-6989470f5440@garyguo.net> References: <20260602-projection-syntax-rework-v2-0-6989470f5440@garyguo.net> <20260602-projection-syntax-rework-v2-1-6989470f5440@garyguo.net> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is a straightforward rename preparing for patch 3 which adds a new `index()` method with panicking semantics (matching `SliceIndex::index` in std). The rename touches the trait definition, the array-to-slice forwarding impl, and the macro call site. Clean mechanical change. The safety doc update correctly replaces `index` with `build_index`: ```rust -/// The implementation of `index` and `get` (if [`Some`] is returned) must ensure that, if provided -/// input pointer `slice` and returned pointer `output`, then: +/// For given input pointer `slice` and return value `output`, the implementation of `build_index` +/// and `get` (if [`Some`] is returned) must ensure that: ``` No issues. Good that this was split out from the feature patch per Alex Courbot's suggestion. --- Generated by Claude Code Patch Reviewer