From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Export symbols for KUnit test modules
Date: Thu, 04 Jun 2026 12:38:58 +1000
Message-ID: <review-patch1-20260602161536.3909009-1-alex.hung@amd.com>
In-Reply-To: <20260602161536.3909009-1-alex.hung@amd.com>
References: <20260602161536.3909009-1-alex.hung@amd.com> <20260602161536.3909009-1-alex.hung@amd.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Correctness: Good.** The three `EXPORT_IF_KUNIT()` additions are placed c=
orrectly =E2=80=94 immediately after the closing brace of each function def=
inition, consistent with all existing uses in the codebase (e.g., `amdgpu_d=
m_psr_fill_caps` at `amdgpu_dm_psr.c:92`, `dm_ism_next_state` at `amdgpu_dm=
_ism.c:131`, etc.).

**Pattern consistency:**
```c
+EXPORT_IF_KUNIT(amdgpu_dm_ism_init);
...
+EXPORT_IF_KUNIT(amdgpu_dm_ism_fini);
...
+EXPORT_IF_KUNIT(amdgpu_dm_psr_set_event);
```
All three follow the same one-liner format used throughout the directory. B=
oth source files already have `#include "amdgpu_dm_kunit_helpers.h"`, so th=
e macro is defined.

**Commit message:** Clear and accurate. The Fixes tags correctly identify t=
he commits that introduced the tests needing these symbols. The `Assisted-b=
y: Copilot:Claude-Opus-4.6` tag is noted.

**Minor nit (non-blocking):** The diff context shows a blank line between `=
amdgpu_dm_ism_init()` and `amdgpu_dm_ism_fini()` at the export location (li=
nes 142-143 in the diff show two blank lines). The `EXPORT_IF_KUNIT(amdgpu_=
dm_ism_init)` is placed before those blank lines, while most other uses in =
the file place the macro right after the closing `}` with one blank line se=
paration before the next function. This is fine =E2=80=94 the existing code=
 already had a double blank line there, and the macro placement is correct.

**No issues found.** The patch is minimal, correct, and follows established=
 conventions.

---
Generated by Claude Code Patch Reviewer