From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: writeback: Document behaviour for framebuffer size mismatch Date: Thu, 04 Jun 2026 12:17:50 +1000 Message-ID: In-Reply-To: <20260602191754.79047-1-derek.foreman@collabora.com> References: <20260602191754.79047-1-derek.foreman@collabora.com> <20260602191754.79047-1-derek.foreman@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness:** The documentation accurately captures a sensible policy. I= t properly handles the three possible outcomes for size mismatch: scale (al= lowed), crop (disallowed), fail (always available as fallback). The "must f= ail instead of partially filling" language is a good addition in v2. **Wording nit:** The phrase "an odd width for a sub-sampled format" at line= 65: ``` + * such as hardware scaler constraints or an odd width for a sub-sampled + * format, the writeback must fail instead of partially filling the buffer. ``` This example is reasonable but slightly tangential =E2=80=94 odd-width-with= -subsampling is more of a general format constraint issue than something sp= ecific to the scaling-vs-mismatch scenario being documented. It's fine as-i= s since it illustrates "unable to exactly fill," but a reviewer could argue= it muddies the focus. Not worth blocking on. **Integration with existing text:** The new text slots in cleanly between t= he description of what `WRITEBACK_FB_ID` stores and the instruction that "U= serspace must set this property to an output buffer every time...". The flo= w reads naturally. **Missing consideration:** The patch doesn't mention whether aspect ratio m= ust be preserved during scaling, or whether arbitrary stretching is permitt= ed. This is presumably left to the driver, which seems fine for now =E2=80= =94 adding aspect ratio constraints could come in a follow-up if needed. **Reviewed-by: Looks good to merge.** --- Generated by Claude Code Patch Reviewer