From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: drm: Add Driver::ParentDevice associated type
Date: Thu, 04 Jun 2026 12:03:16 +1000
Message-ID: <review-patch1-20260603011711.2077361-2-dakr@kernel.org>
In-Reply-To: <20260603011711.2077361-2-dakr@kernel.org>
References: <20260603011711.2077361-1-dakr@kernel.org> <20260603011711.2077361-2-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Clean and straightforward. Adds `ParentDevice<Ctx: DeviceContext>: AsBusDev=
ice<Ctx>` to the `Driver` trait and changes `UnregisteredDevice::new()` to =
take `&T::ParentDevice<Bound>` instead of `&device::Device`.

The one thing worth noting:

```rust
+        dev.as_ref().as_raw(),
```

This relies on the `AsRef<Device>` blanket from `AsBusDevice`. Correct, sin=
ce the trait bound `AsBusDevice<Ctx>: AsRef<Device<Ctx>>` is part of the tr=
ait definition in the kernel tree. No issues.

The nova/tyr driver changes are mechanical =E2=80=94 the `//` formatting co=
mments are just `rustfmt` anchors for import grouping, which is fine.

---
Generated by Claude Code Patch Reviewer