From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: msm: qcm2290: Add Shikra MDSS Date: Fri, 05 Jun 2026 06:28:17 +1000 Message-ID: In-Reply-To: <20260604-shikra-display-v2-1-b3c1b2b67edc@oss.qualcomm.com> References: <20260604-shikra-display-v2-0-b3c1b2b67edc@oss.qualcomm.com> <20260604-shikra-display-v2-1-b3c1b2b67edc@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the substantive patch of the series. The changes are well-structure= d. **select block (qcom,qcm2290-mdss.yaml):** Adding the `select` block is cor= rect and necessary. Since `mdss-common.yaml` uses `select: false`, and none= of the other MDSS binding files in the tree use an explicit `select`, the = default filename-based schema matching would fail for DT nodes whose first = compatible is `qcom,shikra-mdss`. The `contains: enum: [qcom,qcm2290-mdss]`= approach ensures this schema is applied whenever `qcom,qcm2290-mdss` appea= rs anywhere in the compatible list, covering both the standalone and fallba= ck cases. **Title fix:** The title change from `"Qualcomm QCM220 Display MDSS"` to `"= Qualcomm QCM2290 and Shikra Display MDSS"` is a nice drive-by fix of a pre-= existing typo ("QCM220" =E2=86=92 "QCM2290"). **DPU binding (qcom,qcm2290-dpu.yaml):** Minor nit =E2=80=94 the diff remov= es the blank line that separated `compatible:` from `reg:`: ```diff compatible: - const: qcom,qcm2290-dpu - + oneOf: + - const: qcom,qcm2290-dpu + - items: + - const: qcom,shikra-dpu + - const: qcom,qcm2290-dpu reg: ``` The blank line before `reg:` was a visual separator between properties. Its= removal won't break validation, but it's inconsistent with the style in th= e rest of the file and other binding files. Worth keeping for readability. **DSI compatible chain (qcom,qcm2290-mdss.yaml):** The Shikra DSI compatibl= e is defined as a 3-item chain: `qcom,shikra-dsi-ctrl`, `qcom,qcm2290-dsi-c= trl`, `qcom,mdss-dsi-ctrl`. This is correct =E2=80=94 the kernel DSI driver= will match on the `qcom,qcm2290-dsi-ctrl` or `qcom,mdss-dsi-ctrl` fallback= s. **dsi-controller-main.yaml:** Adding `qcom,shikra-dsi-ctrl` in alphabetical= order between `qcom,sdm845-dsi-ctrl` and `qcom,sm6115-dsi-ctrl` is correct. No functional issues found. --- Generated by Claude Code Patch Reviewer