public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: drm: gem: shmem: Add DmaResvGuard helper
Date: Fri, 05 Jun 2026 06:03:37 +1000	[thread overview]
Message-ID: <review-patch1-20260604192740.659240-2-lyude@redhat.com> (raw)
In-Reply-To: <20260604192740.659240-2-lyude@redhat.com>

Patch Review

**Bug — return value of `dma_resv_lock` is ignored:**

```rust
fn new(obj: &'a Object<T, C>) -> Self {
    // SAFETY: This lock is initialized throughout the lifetime of `object`.
    unsafe { bindings::dma_resv_lock(obj.raw_dma_resv(), ptr::null_mut()) };
    Self(obj)
}
```

`dma_resv_lock()` returns `int`. With `ctx` as NULL, `ww_mutex_lock` should succeed (no deadlock detection context), but it can still return `-EALREADY` if the caller already holds the lock. Ignoring the return value means on failure, the `Drop` impl will call `dma_resv_unlock()` on a lock that was never acquired — undefined behavior. At minimum, `new()` should return `Result<Self>` and propagate the error.

**Minor — `#[expect(unused)]` on `new()`:** This attribute is removed in patch 2, which is fine, but the helper itself is dead code in this patch. Consider squashing patches 1 and 2 since the guard has no users until patch 2.

**Comment nit:** The TODO comment about WwMutex is good forward-looking documentation.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04 20:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 19:24 [PATCH v18 0/4] Rust bindings for gem shmem Lyude Paul
2026-06-04 19:24 ` [PATCH v18 1/4] rust: drm: gem: shmem: Add DmaResvGuard helper Lyude Paul
2026-06-04 19:39   ` sashiko-bot
2026-06-04 20:03   ` Claude Code Review Bot [this message]
2026-06-04 19:24 ` [PATCH v18 2/4] rust: drm: gem: shmem: Add vmap functions Lyude Paul
2026-06-04 19:41   ` sashiko-bot
2026-06-04 20:03   ` Claude review: " Claude Code Review Bot
2026-06-04 19:24 ` [PATCH v18 3/4] rust: faux: Allow retrieving a bound Device Lyude Paul
2026-06-04 19:39   ` sashiko-bot
2026-06-04 20:03   ` Claude review: " Claude Code Review Bot
2026-06-04 19:24 ` [PATCH v18 4/4] rust: drm: gem: Introduce shmem::Object::sg_table() Lyude Paul
2026-06-04 19:54   ` sashiko-bot
2026-06-04 20:03   ` Claude review: " Claude Code Review Bot
2026-06-04 20:03 ` Claude review: Rust bindings for gem shmem Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-06-03 19:42 [PATCH v17 0/6] " Lyude Paul
2026-06-03 19:42 ` [PATCH v17 2/6] rust: drm: gem: shmem: Add DmaResvGuard helper Lyude Paul
2026-06-04  1:29   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260604192740.659240-2-lyude@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox