From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] drm/msm/hdmi: make 'msm_hdmi_pm_ops' static
Date: Wed, 11 Mar 2026 13:14:08 +1000 [thread overview]
Message-ID: <review-patch1-2ojzypkvxomlzfv4yb3l5scnkozxxknth2egkfl6ivmo24shju@gfa64pxrmnk6> (raw)
In-Reply-To: <2ojzypkvxomlzfv4yb3l5scnkozxxknth2egkfl6ivmo24shju@gfa64pxrmnk6>
Patch Review
**Verdict: Correct and ready to apply.**
The `DEFINE_RUNTIME_DEV_PM_OPS()` macro expands (via `_DEFINE_DEV_PM_OPS` in `include/linux/pm.h:374`) to:
```c
const struct dev_pm_ops msm_hdmi_pm_ops = { ... }
```
Adding `static` in front is the standard way to limit its scope. The symbol is only referenced within the same file at line 451:
```c
.pm = &msm_hdmi_pm_ops,
```
So making it `static` is correct and silences the sparse warning without any behavioral change.
**Minor nit:** The commit message quotes the sparse warning at line 432:1, which points to the macro invocation. This is fine — sparse reports the expansion site.
No issues found with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 3:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 13:25 [PATCH] drm/msm/hdmi: make 'msm_hdmi_pm_ops' static Ben Dooks
2026-03-10 13:33 ` Dmitry Baryshkov
2026-03-11 3:14 ` Claude review: " Claude Code Review Bot
2026-03-11 3:14 ` Claude Code Review Bot [this message]
2026-03-10 15:17 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-2ojzypkvxomlzfv4yb3l5scnkozxxknth2egkfl6ivmo24shju@gfa64pxrmnk6 \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox