From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: Drop unused include of <drm/drm_pciids.h>
Date: Tue, 05 May 2026 10:38:15 +1000 [thread overview]
Message-ID: <review-patch1-3205129f75aba48bd1ad8fc810cf6a18e718206d.1777545446.git.u.kleine-koenig@baylibre.com> (raw)
In-Reply-To: <3205129f75aba48bd1ad8fc810cf6a18e718206d.1777545446.git.u.kleine-koenig@baylibre.com>
Patch Review
**Status: Good to go.**
The patch removes:
```c
-#include <drm/drm_pciids.h>
```
from `drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c`.
Verified: `amdgpu_drv.c` has no reference to `radeon_PCI_IDS`. The amdgpu driver uses its own PCI ID table defined via `amdgpu_pciidlist[]` and `MODULE_DEVICE_TABLE`. The include is dead code.
No concerns.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-05 0:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 10:45 [PATCH v1 0/3] drm: Drop unused include of <drm/drm_pciids.h> Uwe Kleine-König (The Capable Hub)
2026-04-30 10:45 ` [PATCH v1 1/3] drm/amdgpu: " Uwe Kleine-König (The Capable Hub)
2026-05-05 0:38 ` Claude Code Review Bot [this message]
2026-04-30 10:45 ` [PATCH v1 2/3] drm/gma500: " Uwe Kleine-König (The Capable Hub)
2026-05-05 0:38 ` Claude review: " Claude Code Review Bot
2026-04-30 10:45 ` [PATCH v1 3/3] drm/mgag200: " Uwe Kleine-König (The Capable Hub)
2026-05-04 13:42 ` Thomas Zimmermann
2026-05-05 0:38 ` Claude review: " Claude Code Review Bot
2026-05-05 0:38 ` Claude review: drm: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-3205129f75aba48bd1ad8fc810cf6a18e718206d.1777545446.git.u.kleine-koenig@baylibre.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox