From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: atyfb: Remove unused fb_list Date: Tue, 31 Mar 2026 17:25:36 +1000 Message-ID: In-Reply-To: <571a3e072a2eef5a587d768d74559fc549b03ab6.1774863796.git.geert@linux-m68k.org> References: <571a3e072a2eef5a587d768d74559fc549b03ab6.1774863796.git.geert@linux-m68k.org> <571a3e072a2eef5a587d768d74559fc549b03ab6.1774863796.git.geert@linux-m68k.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Clean** The patch removes two things: 1. The static variable declaration: ```c -static struct fb_info *fb_list = NULL; ``` 2. The assignment in `aty_init()`: ```c - fb_list = info; ``` Both removals are straightforward dead code elimination. The variable was only ever assigned to, never read from, which is exactly what the clang warning reports. No other references to `fb_list` exist in this file (the diff removes all of them), so there's no risk of breaking anything. The commit message properly credits the kernel test robot report and includes the `Closes:` tag linking to the build warning. **Reviewed-by worthy.** No concerns. --- Generated by Claude Code Patch Reviewer