From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] drm/amdgpu: fix inconsistent indenting in amdgpu_gfx_ring_preempt_ib
Date: Sat, 16 May 2026 12:23:11 +1000
Message-ID: <review-patch1-606b422c-4531-4950-a22e-61732383f6b5@amd.com>
In-Reply-To: <606b422c-4531-4950-a22e-61732383f6b5@amd.com>
References: <606b422c-4531-4950-a22e-61732383f6b5@amd.com> <606b422c-4531-4950-a22e-61732383f6b5@amd.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status: Correct, minor commit message nit**

The fix itself is obviously correct. I verified against the current drm-next tree at line 2730 of `amdgpu_gfx.c`:

```c
	/* deassert preemption condition */
    amdgpu_ring_set_preempt_cond_exec(ring, true);
```

The line uses 4 spaces for indentation, while every other line in the function uses tabs. The patch replaces the spaces with a tab:

```c
	/* deassert preemption condition */
	amdgpu_ring_set_preempt_cond_exec(ring, true);
```

This aligns it with the matching call earlier in the function (line 2711):

```c
	/* assert preemption condition */
	amdgpu_ring_set_preempt_cond_exec(ring, false);
```

**Minor nit on commit message:** The commit message says "Fixes a whitespace indentation issue reported by the smatch static checker tool" but doesn't include a `Fixes:` tag pointing to the commit that introduced the bad indentation. For a pure whitespace fix this is arguably unnecessary, but if reviewers want one, it would point to the commit that introduced the space-indented line. This is not a blocker.

**No functional concerns.** The patch is a trivial whitespace-only change with no behavioral impact.

---
Generated by Claude Code Patch Reviewer