From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH v2 1/8] video/hdmi: Add common TMDS character rate constants Date: Mon, 25 May 2026 21:45:01 +1000 Message-ID: In-Reply-To: <87tss215xl.fsf@ocarina.mail-host-address-is-not-set> References: <20260520144424.1633354-1-javierm@redhat.com> <87tss215xl.fsf@ocarina.mail-host-address-is-not-set> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Not present in the mbox** -- cannot review the actual definitions. This is the most important patch to review since it establishes the naming convention, types, and values that all other patches depend on. From the diffstat (`+6` lines in `include/linux/hdmi.h`), it adds approximately 4 `#define` constants. Would need to verify: proper `UL` or type suffixes to avoid signed/unsigned issues (the original `INNO_HDMI_MIN_TMDS_CLOCK` used `U` suffix, `HDMI_PCLK_*` used bare int literals). --- Generated by Claude Code Patch Reviewer