From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: backlight: cgbc_bl: fix kernel-doc comment for struct cgbc_bl_data
Date: Sat, 14 Mar 2026 07:32:09 +1000 [thread overview]
Message-ID: <review-patch1-CAAZVx9_Ki2h-FGemFOhykKvWxayJ26z8ji645Vsj-fdJuH4fZg@mail.gmail.com> (raw)
In-Reply-To: <CAAZVx9_Ki2h-FGemFOhykKvWxayJ26z8ji645Vsj-fdJuH4fZg@mail.gmail.com>
Patch Review
**Status: Correct**
The patch changes:
```
- * CGBC backlight driver data
+ * struct cgbc_bl_data - CGBC backlight driver data
```
This is the correct kernel-doc format for documenting a struct. The `/**` marker at line 29 of `cgbc_bl.c` signals a kernel-doc comment, but without the `struct cgbc_bl_data -` prefix, `scripts/kernel-doc` cannot parse it and emits the warning quoted in the commit message.
I confirmed against the kernel tree that line 30 currently reads `* CGBC backlight driver data` and is immediately followed by `@dev`, `@cgbc`, and `@current_brightness` field descriptions (lines 31-33), with `struct cgbc_bl_data` declared at line 35. The fix correctly names the struct and retains the existing description text after the `-` separator.
**Minor nit (non-blocking):** The `From:` header shows `John S <xaum.io@gmail.com>` while the `Signed-off-by` uses `Kit Dallege <xaum.io@gmail.com>`. The email address matches, but the name mismatch between the author and signoff may raise questions from maintainers. The author should ensure consistency (typically a maintainer would ask which name to use).
Otherwise, no issues. The patch is trivially correct.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-13 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 21:42 [PATCH] backlight: cgbc_bl: fix kernel-doc comment for struct cgbc_bl_data John S
2026-03-13 21:32 ` Claude review: " Claude Code Review Bot
2026-03-13 21:32 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-CAAZVx9_Ki2h-FGemFOhykKvWxayJ26z8ji645Vsj-fdJuH4fZg@mail.gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox