From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: backlight: cgbc_bl: fix kernel-doc comment for struct cgbc_bl_data Date: Sat, 14 Mar 2026 07:32:09 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Correct** The patch changes: ``` - * CGBC backlight driver data + * struct cgbc_bl_data - CGBC backlight driver data ``` This is the correct kernel-doc format for documenting a struct. The `/**` marker at line 29 of `cgbc_bl.c` signals a kernel-doc comment, but without the `struct cgbc_bl_data -` prefix, `scripts/kernel-doc` cannot parse it and emits the warning quoted in the commit message. I confirmed against the kernel tree that line 30 currently reads `* CGBC backlight driver data` and is immediately followed by `@dev`, `@cgbc`, and `@current_brightness` field descriptions (lines 31-33), with `struct cgbc_bl_data` declared at line 35. The fix correctly names the struct and retains the existing description text after the `-` separator. **Minor nit (non-blocking):** The `From:` header shows `John S ` while the `Signed-off-by` uses `Kit Dallege `. The email address matches, but the name mismatch between the author and signoff may raise questions from maintainers. The author should ensure consistency (typically a maintainer would ask which name to use). Otherwise, no issues. The patch is trivially correct. --- Generated by Claude Code Patch Reviewer