From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH v3] staging: fbtft: replace empty macro args with identity converter Date: Mon, 13 Apr 2026 18:50:47 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: NAK =E2=80=94 this patch is broken and must not be applied.** The macro `define_fbtft_write_reg` is defined with 4 parameters: ```c #define define_fbtft_write_reg(func, buffer_type, data_type, modifier) ``` And `modifier` is used as a function-like call in the body (line 25, 42, 55= of the source): ```c buf[i] =3D modifier((data_type)va_arg(args, unsigned int)); ``` The patch changes: ```c -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8) ``` This passes **3 arguments** to a **4-parameter macro**, which is a preproce= ssor error in standard C (C99 =C2=A76.10.3). This would fail to compile. Th= e trailing comma with an empty token was not just whitespace =E2=80=94 it w= as the empty 4th argument, which expands to nothing and effectively makes `= modifier(expr)` become just `(expr)`. The commit message describes this as fixing a "coding style issue reported = by checkpatch.pl," but the proposed fix introduces a build break. --- --- Generated by Claude Code Patch Reviewer