Claude review: drm/amd/display: Deduplicate DCN DDC register assignment

Claude Code Review Bot
2026-03-31T22:00:39Z

Overall Series Review

Subject: drm/amd/display: Deduplicate DCN DDC register assignment
Author: Guilherme Ivo Bozi <guilherme.bozi@usp.br>
Patches: 2
Reviewed: 2026-04-01T08:00:39.540443

---

This is a clean, straightforward deduplication patch (v3) that extracts identical `define_ddc_registers()` bodies from 6 DCN generation files into a shared `static inline` helper in a new header. The approach is sound: the function bodies were truly identical across all 6 files, the types are correct (`struct ddc_sh_mask` matches the actual declarations), and the inline helper avoids any function pointer indirection overhead.

**Verdict: Looks good overall, with minor issues noted below.**