Claude review: drm/amd/display: Deduplicate DCN DDC register assignment

Claude Code Review Bot
2026-03-21T17:15:10Z

Overall Series Review

Subject: drm/amd/display: Deduplicate DCN DDC register assignment
Author: guilhermeivo <guilhermeivob@gmail.com>
Patches: 1
Reviewed: 2026-03-22T03:15:10.293141

---

This is a single-patch cleanup that deduplicates identical `define_ddc_registers()` functions across 6 DCN generations into a shared `static inline` helper in a new header. The idea is sound and the deduplication is worthwhile — the replaced code was truly identical in all 6 files.

However, **the patch has a build-breaking type error** in the new shared helper and should not be merged as-is.