Claude review: Re: [PATCH] staging: fbtft: fix macro whitespace errors

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Result: NAK — breaks compilation**

The macro `define_fbtft_write_reg` is defined with exactly 4 parameters (line 14 of `fbtft-bus.c`):

```c
#define define_fbtft_write_reg(func, buffer_type, data_type, modifier)
```

The `modifier` parameter is used throughout the macro body as a function-like call, for example:

```c
buf[i] = modifier((data_type)va_arg(args, unsigned int));
```

When `modifier` is passed as empty (e.g., `define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )`), the expansion becomes simply `((u8)va_arg(args, unsigned int))` — an identity operation. This is intentional: `fbtft_write_reg8_bus8` needs no byte-order conversion, while `fbtft_write_reg16_bus8` passes `cpu_to_be16` as the modifier.

The patch changes:
```c
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
```

This reduces the argument count from 4 to 3, which will produce a compilation error like:
```
error: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given
```

The same issue applies to the second hunk:
```c
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
```

The checkpatch.pl warning about "space before closing parenthesis" is a **false positive** in this context. The trailing `, )` is the C preprocessor's way of passing an empty argument to a macro — it is not a style issue.

**If the goal is to silence the checkpatch warning**, the correct approach would be to refactor the macro to use variadic arguments (`__VA_ARGS__`) or to define a no-op identity macro (e.g., `#define FBTFT_IDENTITY(x) (x)`) and pass that instead of an empty argument. Simply deleting the argument is not valid.

---
Generated by Claude Code Patch Reviewer