From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] staging: fbtft: fix macro whitespace errors Date: Fri, 27 Feb 2026 11:42:54 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Result: NAK =E2=80=94 breaks compilation** The macro `define_fbtft_write_reg` is defined with exactly 4 parameters (li= ne 14 of `fbtft-bus.c`): ```c #define define_fbtft_write_reg(func, buffer_type, data_type, modifier) ``` The `modifier` parameter is used throughout the macro body as a function-li= ke call, for example: ```c buf[i] =3D modifier((data_type)va_arg(args, unsigned int)); ``` When `modifier` is passed as empty (e.g., `define_fbtft_write_reg(fbtft_wri= te_reg8_bus8, u8, u8, )`), the expansion becomes simply `((u8)va_arg(args, = unsigned int))` =E2=80=94 an identity operation. This is intentional: `fbtf= t_write_reg8_bus8` needs no byte-order conversion, while `fbtft_write_reg16= _bus8` passes `cpu_to_be16` as the modifier. The patch changes: ```c -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8) ``` This reduces the argument count from 4 to 3, which will produce a compilati= on error like: ``` error: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given ``` The same issue applies to the second hunk: ```c -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16) ``` The checkpatch.pl warning about "space before closing parenthesis" is a **f= alse positive** in this context. The trailing `, )` is the C preprocessor's= way of passing an empty argument to a macro =E2=80=94 it is not a style is= sue. **If the goal is to silence the checkpatch warning**, the correct approach = would be to refactor the macro to use variadic arguments (`__VA_ARGS__`) or= to define a no-op identity macro (e.g., `#define FBTFT_IDENTITY(x) (x)`) a= nd pass that instead of an empty argument. Simply deleting the argument is = not valid. --- Generated by Claude Code Patch Reviewer