From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vkms: Constify struct configfs_item_operations and configfs_group_operations Date: Tue, 26 May 2026 07:16:38 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Clean** The patch adds `const` to 13 structure definitions across `drivers/gpu/drm/vkms/vkms_configfs.c`: - 8 `configfs_item_operations` instances: `crtc_item_operations`, `plane_possible_crtcs_item_operations`, `plane_item_operations`, `encoder_possible_crtcs_item_operations`, `encoder_item_operations`, `connector_item_operations`, `connector_possible_encoders_item_operations`, `device_item_operations` - 5 `configfs_group_operations` instances: `crtcs_group_operations`, `planes_group_operations`, `encoders_group_operations`, `connectors_group_operations`, `device_group_ops` All of these are statically initialized with function pointers and never modified after initialization, making `const` appropriate. The parent `config_item_type` struct stores these via `const` pointers, so no cast or type mismatch is introduced. The size data in the commit message is consistent: `text` increases by 992 bytes, `data` decreases by 992 bytes, and the total (`dec`) stays at 31778, confirming the structures moved from `.data` to `.rodata` as expected. No correctness, style, or completeness issues. **Reviewed-by: appropriate.** --- Generated by Claude Code Patch Reviewer